]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
slider: Use Clutter.grab() for implicit grab
authorCarlos Garnacho <carlosg@gnome.org>
Wed, 17 Nov 2021 23:00:52 +0000 (00:00 +0100)
committerCarlos Garnacho <carlosg@gnome.org>
Sat, 29 Jan 2022 00:16:29 +0000 (01:16 +0100)
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2045>

js/ui/slider.js

index ba3a233f15814502011f679501ed0d37f31823c7..6ca76fec0b1605a5e9e199f3b9398667c24bd640 100644 (file)
@@ -73,10 +73,7 @@ var Slider = GObject.registerClass({
         let device = event.get_device();
         let sequence = event.get_event_sequence();
 
-        if (sequence != null)
-            device.sequence_grab(sequence, this);
-        else
-            device.grab(this);
+        this._grab = global.stage.grab(this);
 
         this._grabbedDevice = device;
         this._grabbedSequence = sequence;
@@ -98,10 +95,10 @@ var Slider = GObject.registerClass({
                 this._releaseId = 0;
             }
 
-            if (this._grabbedSequence != null)
-                this._grabbedDevice.sequence_ungrab(this._grabbedSequence);
-            else
-                this._grabbedDevice.ungrab();
+            if (this._grab) {
+                this._grab.dismiss();
+                this._grab = null;
+            }
 
             this._grabbedSequence = null;
             this._grabbedDevice = null;
@@ -121,14 +118,14 @@ var Slider = GObject.registerClass({
 
     vfunc_touch_event() {
         let event = Clutter.get_current_event();
-        let device = event.get_device();
         let sequence = event.get_event_sequence();
 
         if (!this._dragging &&
             event.type() == Clutter.EventType.TOUCH_BEGIN) {
             this.startDragging(event);
             return Clutter.EVENT_STOP;
-        } else if (device.sequence_get_grabbed_actor(sequence) == this) {
+        } else if (this._grabbedSequence &&
+                   sequence.get_slot() === this._grabbedSequence.get_slot()) {
             if (event.type() == Clutter.EventType.TOUCH_UPDATE)
                 return this._motionEvent(this, event);
             else if (event.type() == Clutter.EventType.TOUCH_END)